Skip to content

net: harden multiwan apply and restore rollback - #158

Merged
Cd1s merged 4 commits into
mainfrom
fix/audit-leftovers
Oct 18, 2026
Merged

Cd1s merged 4 commits into
mainfrom
fix/audit-leftovers

Conversation

@Cd1s

@Cd1s Cd1s commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

What

  • exempt only unchanged PPPoE backup lines from post-apply rollback when another WAN is online or the link has no carrier; changed PPPoE settings remain strict
  • account for per-WAN multi-WAN dial-order waits with a 300-second cap and record restart times so stale leases cannot satisfy a new dial
  • preserve restore list snapshots through armConfirm, persist a pre-apply restore marker, and restore lists on explicit, automatic, or boot rollback
  • allocate stable IPv6 PD SLA IDs to RA-enabled LAN networks, keep the legacy main-LAN PD request, and diagnose missing extra-network prefixes
  • recognize OpenSSH without trying to manage it as dropbear, and discover Linux Chromium/Chrome in tools/cdpshot.py

Why

The audit leftovers could accept an incorrect changed PPPoE password, lose list rollback metadata at the confirmation transition, leave restored lists after a power loss before the apply worker claimed its marker, and omit extra IPv6 LAN networks from delegated prefixes and firewall classification.

Verification

  • gofmt -l .
  • go vet ./...
  • go test -count=1 ./...
  • python3 tools/test_cdpshot.py
  • sh -n install.sh
  • sh tools/ci.sh — ALL CHECKS PASSED

Closes #156

@Cd1s
Cd1s merged commit 0f37e7f into main Oct 18, 2026
2 checks passed
@Cd1s Cd1s mentioned this pull request Oct 18, 2026
52 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

net: harden multiwan apply, restore rollback, and IPv6 LAN handling

1 participant