Fix overflow while parsing in system.zookeeper_info#111629
Open
kssenii wants to merge 2 commits into
Open
Conversation
All numeric fields of the four letter command responses were parsed into 32-bit int: Zxid via overflow-checked parseIntInBase, so any zxid above 2^31 - 1 made a query to the table fail with CANNOT_PARSE_NUMBER exception "Overflow while parsing a number", and the remaining fields via unchecked parse<int>, so values above 2^31 - 1 silently wrapped around. Parse Zxid as Int64 and the rest as UInt64, matching the column types. Return NULL for zk_open_file_descriptor_count and zk_max_file_descriptor_count, where Keeper reports -1 when it cannot determine the value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [c38cc9a] AI ReviewSummaryThis PR fixes Final Verdict
|
alesapin
approved these changes
Jul 23, 2026
alesapin
left a comment
Member
There was a problem hiding this comment.
LGTM, just be sure that XID and ZXID are signed (they are).
The old version cannot be pinned by a moving tag like 26.2, which will receive the fix through a backport. The current-version assertions alone fail without the fix, so the pinned instance is not needed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix overflow while parsing in system.zookeeper_info