Skip to content

Accept HTML banner markup in PyPI verification #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaoyuanLi2816 merged 1 commit into from
Jul 30, 2026
Merged

Accept HTML banner markup in PyPI verification #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions scripts/verify_pypi_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,42 @@
import urllib.error
import urllib.parse
import urllib.request
from html.parser import HTMLParser
from pathlib import Path
from typing import Any

_INTEGRITY_MEDIA_TYPE = "application/vnd.pypi.integrity.v1+json"


class _PinnedImageParser(HTMLParser):
def __init__(self, target: str) -> None:
super().__init__()
self.target = target
self.alts: list[str] = []

def handle_starttag(
self,
tag: str,
attrs: list[tuple[str, str | None]],
) -> None:
if tag != "img":
return
attributes = dict(attrs)
alt = attributes.get("alt")
if attributes.get("src") == self.target and alt:
self.alts.append(alt)


def _pinned_image_alts(description: str, target: str) -> list[str]:
markdown_alts = re.findall(
rf"!\[([^\]]+)\]\({re.escape(target)}\)",
description,
)
parser = _PinnedImageParser(target)
parser.feed(description)
return [*markdown_alts, *parser.alts]


def _request_json(url: str, *, accept: str = "application/json") -> dict[str, Any]:
request = urllib.request.Request(
url,
Expand Down Expand Up @@ -135,10 +165,7 @@ def _verify_long_description_links(
if f"{github}/blob/main/" in description or f"{raw}/main/" in description:
raise RuntimeError("stable PyPI long description still links repository files through main")

image_matches = re.findall(
rf"!\[([^\]]+)\]\({re.escape(required_image_url)}\)",
description,
)
image_matches = _pinned_image_alts(description, required_image_url)
if not image_matches:
raise RuntimeError(
"PyPI long description does not use the release-pinned banner as an image"
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_pypi_release_verifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def test_long_description_can_defer_a_client_challenge_to_browser_inspection(
)
banner = f"https://raw.githubusercontent.com/DaoyuanLi2816/mini-verl/{tag}/docs/banner.svg"
links = [f"{repository}/blob/{tag}/{path}" for path in paths]
description = "\n".join([*links, f"![release banner]({banner})"])
description = "\n".join([*links, f'<img src="{banner}" alt="release banner" width="880">'])
monkeypatch.setattr(
verifier,
"_request_json",
Expand Down