Serialize the Pages deploy job across refs - #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deploy versioned documentationjob failed on thev0.6.1tag push (run 30857762945), while themainbuild for the same release succeeded.Cause: the workflow-level concurrency group is
docs-${{ github.ref }}. A release produces two pushes with different refs —refs/heads/mainandrefs/tags/v0.6.1— so they land in separate groups and run at the same time. Both then try to claim the singlegithub-pagesenvironment, and one deployment loses. The deployment record confirms it:github-pagesfor refv0.6.1isfailure, and the latermaindeployment issuccess, which is why the site itself is fine.This adds a job-level
concurrency: pagesto the deploy job only, so deployments serialize across every ref while the build and visual-gate jobs keep running in parallel per ref. Without it the race repeats on every tagged release.Verified
.github/workflows/docs.ymlstill parses as YAML. The real check is the workflow run on this PR.