Skip to content

[openui5] Add deprecation notice - #75751

Open
akudev wants to merge 1 commit into
DefinitelyTyped:masterfrom
akudev:openui5_deprecation
Open

akudev wants to merge 1 commit into
DefinitelyTyped:masterfrom
akudev:openui5_deprecation

Conversation

@akudev

@akudev akudev commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Please fill in this template.

Changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

Change is documentation only, it does not change the types.

@typescript-automation

typescript-automation Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

@akudev Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75751,
  "author": "akudev",
  "headCommitOid": "907d8916f35b317cc869931234f98d40fa225799",
  "mergeBaseOid": "fa817f124291dc323e21eca7f252c8ca8bc4d204",
  "lastPushDate": "2026-10-09T15:18:40.000Z",
  "lastActivityDate": "2026-10-10T03:58:06.000Z",
  "mergeOfferDate": "2026-10-09T15:35:29.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "openui5",
      "version": "1.153",
      "kind": "edit",
      "files": [
        {
          "path": "types/openui5/README.md",
          "kind": "markdown"
        }
      ],
      "owners": [
        "openui5bot",
        "petermuessig",
        "codeworrior",
        "akudev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "codeworrior",
      "date": "2026-10-09T15:34:46.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 6083820935,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. labels Oct 9, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @openui5bot @petermuessig @codeworrior — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-automation typescript-automation Bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 9, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

@akudev: Everything looks good here. I am ready to merge this PR (at 907d891) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@openui5bot, @petermuessig, @codeworrior: you can do this too.)

@hkleungai

Copy link
Copy Markdown
Contributor

I think there is a more "common" way to deprecate things in this repo. See https://github.com/DefinitelyTyped/DefinitelyTyped#removing-a-package.

A deprecation notice hidden deep inside node_modules may quite easily be overlooked in a large-scale project. Better let npm itself to do the deprecation reporting to downstream users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Waiting for Author to Merge

Development

Successfully merging this pull request may close these issues.

3 participants