Repository navigation
Deprecate horovod in favor of torch.distributed - #171
Merged
Merged
Conversation
added 3 commits
June 2, 2022 11:20
Owner
|
@vwxyzjn Ill take a look. But overall looks awesome and much easier to use :) it takes a few hours of pain to install horovod for average person :) |
Contributor
Author
|
Thank you @Denys88
Yes, it should be enough to call it on rank=0 GPU, al least in the case of isaacgymenvs when thousands of envs are available |
Denys88
reviewed
Jun 3, 2022
| should_exit_t = torch.tensor(should_exit).float() | ||
| self.hvd.broadcast_value(should_exit_t, 'should_exit') | ||
| should_exit = should_exit_t.bool().item() | ||
| # if self.multi_gpu: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up with #165 #158
We did a benchmark with isaacgymenvs and
torch.distributedshows consistently better scaling performance inAllegroHand.Notable change - I disable the stats syncing, which does not seem to be that important to average across all workers at every step.
You can test it out with
CC @ViktorM @markelsanz14