Skip to content

feat(web): type a machine or model name, press Tab to make it a chip - #5

Open
DominikScholz wants to merge 2508 commits into
mainfrom
feat/composer-inline-completions
Open

DominikScholz wants to merge 2508 commits into
mainfrom
feat/composer-inline-completions

Conversation

@DominikScholz

@DominikScholz DominikScholz commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Naming a machine or model meant typing @, finding it in a menu, and clicking. It should work like code completion: start typing the name and it's already there. Now, from the third letter and with no @, the rest of the name appears as gray text after the cursor. Tab turns it into a chip that tells the agent exactly which one you mean, and Esc dismisses it.

This one is opinionated: Tab means "accept" while a suggestion is showing. It keeps its usual meaning otherwise, and nothing is inserted unless you press it.

Before After
before after
  • The ghost text is a ProseMirror decoration, so it updates in the same frame as the keystroke and adds no React state. Only typing proposes a name: moving the caret, pasting, undoing and restoring a draft don't.
  • Model chips use the existing unknown-kind record shape instead of a new contract kind, so older servers and clients already accept them. The agent gets the provider instance and model to pass to delegate_task.
  • Machines are only offered with the Linked environments beta on, same as the @ menu.
  • Web and desktop only. A React Native text input has no ghost text or Tab key, so mobile doesn't offer completions.
  • There is no settings toggle.

Proof: composerInlineSuggestion.test.ts, a browser test covering draw, Tab, Esc, paste and formatting boundaries, and a draft-persistence test. I also drove it in the running app and sent through the replay provider, where both chips rendered in the timeline with the right records. The video was captured at 1/3 speed for smooth playback, then sped back up. vp run check:changed passes. The model chip's guidance is model-facing and the paid evals were not run, since no API keys were available.

Reviewed with sol-loop: 2 rounds with gpt-6.1-sol. Sol verdict: approved

Created with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Nov 6, 2026
@DominikScholz
DominikScholz force-pushed the feat/composer-inline-completions branch from f252cf0 to a7b5762 Compare November 6, 2026 11:25
@github-actions github-actions Bot added size:XXL and removed size:L labels Nov 6, 2026
juliusmarminge and others added 25 commits November 15, 2026 12:34
…ingdotgg#37206)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: GPT 6.1 Sol <codex@openai.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…iew (pingdotgg#37340)

Co-authored-by: cmcgrabby-hue <267390149+cmcgrabby-hue@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ds (pingdotgg#37364)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ode's hand-back frame (pingdotgg#37355)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#37395)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#37083)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge and others added 30 commits November 16, 2026 23:43
…gg#36624)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…has no matches (pingdotgg#37971)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#38017)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gg#38021)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dy (pingdotgg#38025)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ore fails (pingdotgg#38035)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…completions

# Conflicts:
#	apps/web/src/components/ComposerPromptEditorTiptap.input.browser.test.tsx
#	packages/client-runtime/package.json
…art (pingdotgg#38043)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
main's composer paste handler tags its own transactions instead of ProseMirror's uiEvent, so the
suggestion plugin read the pasted text as typing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tion

The appended transaction that hides Markdown source after a caret move changed the document
without typing, so the suggestion plugin read it as typing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… name

Only normalization appended to a caret move is ignored now, so a keystroke the source
history replays after an undo can still start a suggestion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…it saves (pingdotgg#38031)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
A path like @src/(cla drew a model suggestion inside the open @ menu, and Tab took the
suggestion instead of the menu item.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.