Fix critical stability bugs and memory leaks - #32
Open
Manamama-Gemini-Cloud-AI-01 wants to merge 1 commit into
Open
Manamama-Gemini-Cloud-AI-01 wants to merge 1 commit into
Manamama-Gemini-Cloud-AI-01 wants to merge 1 commit into
Conversation
1. Fix segmentation fault during --list due to uninitialized memory (added memset to malloc calls). 2. Fix negative width specifier in printf within print_bench_types_cpu. 3. Add missing cleanup functions: exit_benchmark, free_hardware, free_benchmark_cpu, free_cpu_info, free_config. 4. Fix memory leaks in main.cpp and arch.cpp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several critical stability issues identified while testing the project.
Changes:
memsetto allmalloccalls for core structures (benchmark,benchmark_cpu, andcpu). This prevents segmentation faults during cleanup by ensuring pointers areNULLunless explicitly initialized.print_bench_types_cpuwhere a negative padding width was passed toprintf.exit_benchmark,free_hardware, etc.) and added them to the execution paths inmain.cppto prevent memory leaks.init_benchmark_cpuwherethread_setwas not being freed.Fixes #30