Skip to content

Raise fixed-schema Excel table default to 5 million cells - #2327

Merged
PrzemyslawKlys merged 2 commits into
masterfrom
codex/table-resource-policy
Aug 14, 2026
Merged

PrzemyslawKlys merged 2 commits into
masterfrom
codex/table-resource-policy

Conversation

@PrzemyslawKlys

@PrzemyslawKlys PrzemyslawKlys commented Aug 13, 2026

Copy link
Copy Markdown
Member

What changed

  • raises the bounded fixed-schema DataTable default from 2,000,000 to 5,000,000 cells
  • keeps MaxRows, MaxColumns, and MaxCells explicitly caller-configurable
  • keeps the O(1) preflight and optimized fixed-schema writer unchanged
  • updates the Excel README and migration guidance for the new default
  • removes a self-referential constant assertion while retaining functional limit-enforcement coverage

Why 5 million

The default is a resource-policy guardrail, not an out-of-memory prediction. Benchmarks on the existing saved-workbook DataTable scenario measured about 0.70 seconds / 171 MB total allocation at 2 million cells, 1.19 seconds / 387 MB at 5 million, and 1.83 seconds / 705 MB at 8.39 million. Five million accommodates common reporting workloads such as roughly 100,000 rows by 40 columns while retaining a finite default for unattended or tenant-controlled generation. Actual cost still varies with string sizes, styles, and workbook features.

Base

The safety enforcement and actionable override guidance from #2323 are now on master. This PR is rebased on that merged implementation and changes only the fixed-schema default plus its public guidance.

@PrzemyslawKlys
PrzemyslawKlys force-pushed the codex/table-resource-policy branch from 9fc1ece to fa55d8c Compare August 13, 2026 11:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa55d8c0d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Excel.Tests/Excel.SheetComposer.DataTable.cs Outdated
Comment thread OfficeIMO.Excel/Fluent/SheetComposer.Table.DataTable.cs
@PrzemyslawKlys
PrzemyslawKlys force-pushed the codex/table-resource-policy branch from ac2c200 to 33287a2 Compare August 13, 2026 12:10
Base automatically changed from codex/security-remediation-20260812 to master August 14, 2026 09:25
@PrzemyslawKlys
PrzemyslawKlys force-pushed the codex/table-resource-policy branch from 33287a2 to 290bb65 Compare August 14, 2026 10:13
@PrzemyslawKlys
PrzemyslawKlys merged commit 90edb6a into master Aug 14, 2026
69 checks passed
@PrzemyslawKlys
PrzemyslawKlys deleted the codex/table-resource-policy branch August 14, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant