Request - Add support to output path to subtitle_list plugin

Expected behaviour:

In the former subtitle_queue plugin, we could add the subtitles to the queue with the destination path, instead of the current one, and with this, we could move the files and the add the subtitles to the queue in the same task, and the subtitles would be downloaded to the final path.

Actual behaviour:

It doesnt support the path option anymore, so its going to emit paths that do not exist anymore, because the file was previouslly moved.

Steps to reproduce:

Step 1: Move a file and add it to the subtitle list in the same task
Step 2: Emit the subtitle list

Config:

move task:

  move-movies:
    template:
      - disable-seen-retry
      - movies-metainfo
    filesystem:
      path: '/{{secrets.folder.root}}{{secrets.folder.downmovies}}'
      recursive: yes
      retrieve: files
      regexp: '.*\.(avi|mkv|mp4)$'
    accept_all: yes
    move:
      to: '/{{secrets.folder.root}}{{secrets.folder.movies}}'
      filename: "{{tmdb_name|pathscrub}} ({{tmdb_year}}){% if quality|default(False) %}: - [{{quality}}]{% endif %}"
      clean_source: 100
    list_add:
      - subtitle_list:
          list: subtitles-list

subtitle download task:

  download-subtitles:
    template:
      - disable-seen-retry
    subtitle_list:
      list: subtitles-list
    list_queue:
      - subtitle_list:
          list: subtitles-list
    subliminal:
      exact_match: yes
      languages:
        - eng

Log:

move task:

2016-06-05 19:34 VERBOSE  task          move-movies     ACCEPTED: `Beginners (2010) - [720p bluray h264]` by accept_all plugin
2016-06-05 19:34 VERBOSE  details       move-movies     Summary - Accepted: 1 (Rejected: 0 Undecided: 0 Failed: 0)
2016-06-05 19:34 VERBOSE  move          move-movies     Adding extension `.mp4` to dst `/mnt/data/Movies/Beginners (2010) - [720p bluray h264]`
2016-06-05 19:34 INFO     move          move-movies     `/mnt/data/Downloads/Movies/Beginners/Beginners (2010) - [720p bluray h264].mp4` has been moved to `/mnt/data/Movies/Beginners (2010) - [720p bluray h264].mp4`
2016-06-05 19:34 INFO     move          move-movies     Path `/mnt/data/Downloads/Movies/Beginners` has been deleted because was less than clean_source safe value.
2016-06-05 19:34 VERBOSE  list_add      move-movies     adding accepted entries into subtitle_list - {u'list': u'subtitles-list', u'check_subtitles': True}

subtitle download task:

2016-06-05 19:39 ERROR    subtitle_list download-subtitles File /mnt/data/Downloads/Movies/Beginners/Beginners (2010) - [720p bluray h264].mp4 does not exist. Removing from list.
2016-06-05 19:39 VERBOSE  details       download-subtitles Task didn't produce any entries.
2016-06-05 19:39 VERBOSE  details       download-subtitles Summary - Accepted: 0 (Rejected: 0 Undecided: 0 Failed: 0)

Additional information:

Flexget Version: 2.0.40
Python Version: 2.7.11
Installation method: pip
OS and version: Fedora 23

@gazpachoking

Hmm, this is actually something I've discussed with @gazpachoking. It is my belief that move and download (and other such plugins) should set the location field rather than the output field.

This should help you achieve what you want, right?

It does make sense, but its not something that is already available, right?

What about tasks that deal with torrents tho?
In my case I'm using rTorrent; the download plugin may download the torrent file somewhere, but the path where the actual files will be downloaded is a different matter altogether.

God dammit, I removed that feature because it was a mess :D

subtitle_queue allowed you to queue the torrent contents, but there's no standardized way of doing this what with move_done, multifile torrents, singlefile torrents etc. So I removed that feature from subtitle_list.

I could introduce a path config option that supports jinja replacement. Does that cater to you both?

I never used it together with move_done, so i had no idea, but that does sound like a problem.

If the path does the same thing that it used to do in subtitle_queue, then yes, that would be great.

Thanks

I agree, the path property would make it simple enough to do what I need.
Thanks for taking my comment into consideration :D

I don't think path will suffice for what you want. path in your case will be a directory and not a file.

Well yeah, that's what I asumed. Isn't that how the subtitle_queue's path works?

subtitle_list operates solely on files atm

added some requested features to subtitle_list, closes #1224 (#1229)

Navigation Menu

Repository navigation

Request - Add support to output path to subtitle_list plugin #1224

Expected behaviour:

Actual behaviour:

Steps to reproduce:

Config:

Log:

Additional information:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Request - Add support to output path to subtitle_list plugin #1224

Description

Expected behaviour:

Actual behaviour:

Steps to reproduce:

Config:

Log:

Additional information:

Activity

cvium commented on Jun 5, 2016

Jonybat commented on Jun 5, 2016

asermax commented on Jun 6, 2016

cvium commented on Jun 6, 2016

Jonybat commented on Jun 6, 2016

asermax commented on Jun 6, 2016

cvium commented on Jun 6, 2016

asermax commented on Jun 6, 2016

cvium commented on Jun 6, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions