Skip to content

feat: add 'normalize' config option to torznab plugin - #4781

Open
pogman-code wants to merge 1 commit into
Flexget:developfrom
pogman-code:develop
Open

pogman-code wants to merge 1 commit into
Flexget:developfrom
pogman-code:develop

Conversation

@pogman-code

Copy link
Copy Markdown
Contributor

Hello,
As I discussed earlier in #4780, some torznab indexer are not very friendly with special chars.
So the proposed change is to add an optional config to the plugin to normalize strings for queries

torznab:
  normalize: none/unicode/scene

@codecov

codecov Bot commented Dec 13, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.40%. Comparing base (0abff41) to head (290566c).
⚠️ Report is 460 commits behind head on develop.

Files with missing lines Patch % Lines
flexget/plugins/input/torznab.py 14.28% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (14.28%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4781      +/-   ##
===========================================
- Coverage    66.40%   66.40%   -0.01%     
===========================================
  Files          583      583              
  Lines        53898    53903       +5     
  Branches      6934     6936       +2     
===========================================
  Hits         35793    35793              
- Misses       16583    16588       +5     
  Partials      1522     1522              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paranoidi

Copy link
Copy Markdown
Member

Wouldn't this be better in discover plugin so that it benefits any possible search plugin?

@pogman-code

Copy link
Copy Markdown
Contributor Author

Wouldn't this be better in discover plugin so that it benefits any possible search plugin?

It's not that trivial because search plugins can use various entry properties (title, series_name, imdb_name, imdb_id, etc.)

@pogman-code

Copy link
Copy Markdown
Contributor Author

Hi, sorry to bump this but should I change something and/or is it a bad idea/approach?

@paranoidi

Copy link
Copy Markdown
Member

@pogman-code Hi, apologies for the delay. No worries about bumping the PR. It's not necessarily a bad idea, but this does come up occasionally in various different contexts and thus a more generic solution would be preferable.

Best idea that I've come up so far is normalizer plugin type which can be plugged into any (supporting) plugin. Aside from generic remove special characters these could be made for very specific use-cases like movie titles and have options such as strip or include the year.

@gazpachoking Thoughts?

@paranoidi

Copy link
Copy Markdown
Member

Just a note, I did end up trying couple different generic normalizers implemented. But I didn't yet come up with a solution that would be satisfactory on all fronts.

@pogman-code

Copy link
Copy Markdown
Contributor Author

Just a note, I did end up trying couple different generic normalizers implemented. But I didn't yet come up with a solution that would be satisfactory on all fronts.

I poked around to find something too to no avail, but I blamed my lack of knowledge in the codebase 😅

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions Bot added the Stale label Aug 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants