Repository navigation
feat: add 'normalize' config option to torznab plugin - #4781
pogman-code wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (14.28%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4781 +/- ##
===========================================
- Coverage 66.40% 66.40% -0.01%
===========================================
Files 583 583
Lines 53898 53903 +5
Branches 6934 6936 +2
===========================================
Hits 35793 35793
- Misses 16583 16588 +5
Partials 1522 1522 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Wouldn't this be better in discover plugin so that it benefits any possible search plugin? |
It's not that trivial because search plugins can use various entry properties (title, series_name, imdb_name, imdb_id, etc.) |
|
Hi, sorry to bump this but should I change something and/or is it a bad idea/approach? |
|
@pogman-code Hi, apologies for the delay. No worries about bumping the PR. It's not necessarily a bad idea, but this does come up occasionally in various different contexts and thus a more generic solution would be preferable. Best idea that I've come up so far is normalizer plugin type which can be plugged into any (supporting) plugin. Aside from generic remove special characters these could be made for very specific use-cases like movie titles and have options such as strip or include the year. @gazpachoking Thoughts? |
|
Just a note, I did end up trying couple different generic normalizers implemented. But I didn't yet come up with a solution that would be satisfactory on all fronts. |
I poked around to find something too to no avail, but I blamed my lack of knowledge in the codebase 😅 |
|
This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days. |
Hello,
As I discussed earlier in #4780, some torznab indexer are not very friendly with special chars.
So the proposed change is to add an optional config to the plugin to normalize strings for queries