Migrate to Room 3 - #295
Merged
Merged
Conversation
# Conflicts: # service/src/main/kotlin/com/github/kr328/clash/service/data/migrations/Migrations.kt
There was a problem hiding this comment.
Pull request overview
This PR migrates the service module’s persistence layer from Room 2 (androidx.room) to Room 3 (androidx.room3), aligning the codebase with Room 3’s coroutine-first APIs and updated artifacts.
Changes:
- Switched Room imports in DAOs/entities/type converters/database to
androidx.room3. - Updated DAO write methods to
suspendand adjusted a synchronous call site to use a coroutine. - Updated Gradle dependencies/version catalog to use
androidx.room3:*artifacts and removedroom-ktx.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| service/src/main/kotlin/com/github/kr328/clash/service/data/SelectionDao.kt | Migrates DAO annotations to Room 3 and makes write APIs suspend. |
| service/src/main/kotlin/com/github/kr328/clash/service/data/Selection.kt | Migrates entity annotations/imports to Room 3. |
| service/src/main/kotlin/com/github/kr328/clash/service/data/RoomTypeConverters.kt | Migrates type converter annotation import to Room 3. |
| service/src/main/kotlin/com/github/kr328/clash/service/data/PendingDao.kt | Migrates DAO annotations/imports to Room 3. |
| service/src/main/kotlin/com/github/kr328/clash/service/data/Pending.kt | Migrates entity annotations/imports to Room 3. |
| service/src/main/kotlin/com/github/kr328/clash/service/data/ImportedDao.kt | Migrates DAO annotations/imports to Room 3. |
| service/src/main/kotlin/com/github/kr328/clash/service/data/Imported.kt | Migrates entity annotations/imports to Room 3. |
| service/src/main/kotlin/com/github/kr328/clash/service/data/Database.kt | Migrates database definition/builder imports to Room 3. |
| service/src/main/kotlin/com/github/kr328/clash/service/ClashManager.kt | Adjusts selection persistence call site for suspend DAO APIs. |
| service/build.gradle.kts | Removes room-ktx and keeps Room compiler/runtime wiring via KSP. |
| gradle/libs.versions.toml | Updates Room version and switches artifacts to androidx.room3:*. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.