Skip to content

Conversation

@dyl10s
Copy link
Collaborator

@dyl10s dyl10s commented Jul 18, 2025

Description

Refactor the Redis logging to use LoggingReceiverMacro

Related issue

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@google-cla
Copy link

google-cla bot commented Jul 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

},
}.Components(ctx, tag, uid)

// Log levels documented: https://github.com/redis/redis/blob/6.2/src/server.c#L1124
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this comment since it seems relevant to the Redis receiver implementation.

@@ -0,0 +1,335 @@
- entries:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some test failures regarding this logging_processor-redis transformation test. This is probably because there is a mis-match with the expected output. Executing make transformation_test_update may solve the issue.

@franciscovalentecastro
Copy link
Contributor

franciscovalentecastro commented Jul 22, 2025

Update :

Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@franciscovalentecastro
Copy link
Contributor

All integration test failures are unrelated to this PR update. There a lot instances of passing redis tests. Merging.

@franciscovalentecastro franciscovalentecastro merged commit 19edf93 into GoogleCloudPlatform:master Jul 24, 2025
53 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants