-
Notifications
You must be signed in to change notification settings - Fork 77
feat: Update Redis receiver to use LoggingReceiverMacro
#1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Redis receiver to use LoggingReceiverMacro
#1985
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| }, | ||
| }.Components(ctx, tag, uid) | ||
|
|
||
| // Log levels documented: https://github.com/redis/redis/blob/6.2/src/server.c#L1124 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this comment since it seems relevant to the Redis receiver implementation.
| @@ -0,0 +1,335 @@ | |||
| - entries: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some test failures regarding this logging_processor-redis transformation test. This is probably because there is a mis-match with the expected output. Executing make transformation_test_update may solve the issue.
9e88fbb to
0e92101
Compare
|
Update :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
All integration test failures are unrelated to this PR update. There a lot instances of passing |
19edf93
into
GoogleCloudPlatform:master
Description
Refactor the Redis logging to use
LoggingReceiverMacroRelated issue
How has this been tested?
Checklist: