Skip to content

Conversation

@franciscovalentecastro
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro commented Jul 22, 2025

Description

Facing some issues in #1985 when un-marshalling double quoted strings with escape sequences (e.g. " /t " was not un-marshalled correctly).

Context

The issue was fixed and released in version v1.14.2. See details :

Related issue

b/413410475

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro requested review from a team and LujieDuan and removed request for a team July 22, 2025 21:47
@franciscovalentecastro franciscovalentecastro force-pushed the fcovalente-update-go-yaml-v1.18.0 branch from a7bd0c6 to 5492d80 Compare July 23, 2025 16:25
@franciscovalentecastro franciscovalentecastro changed the title Upgrade github.com/goccy/go-yaml to v1.18.0. Upgrade github.com/goccy/go-yaml to v1.14.2. Jul 23, 2025
Copy link
Contributor

@LujieDuan LujieDuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@franciscovalentecastro franciscovalentecastro force-pushed the fcovalente-update-go-yaml-v1.18.0 branch from 5492d80 to 078ee20 Compare July 23, 2025 19:15
@franciscovalentecastro franciscovalentecastro merged commit beaee9c into master Jul 23, 2025
60 of 68 checks passed
@franciscovalentecastro franciscovalentecastro deleted the fcovalente-update-go-yaml-v1.18.0 branch July 23, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants