Skip to content

confgenerator: preserve response_code for agent self metrics #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

confgenerator: preserve response_code for agent self metrics #780

merged 1 commit into from
Aug 9, 2022

Conversation

@ridwanmsharif
Copy link
Contributor

@ridwanmsharif ridwanmsharif commented Aug 4, 2022

This change preserves the response_code label on self metrics where
appropriate. See the spec for more details.

Note: This requires a change in Fluent Bit befoe merging. See
fluent/fluent-bit#5836 for more details.

Signed-off-by: Ridwan Sharif ridwanmsharif@google.com

@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/self-metrics-response-code branch 5 times, most recently from 603a93f to 84b99a5 Compare August 4, 2022 18:06
rafaelwestphal
rafaelwestphal requested changes Aug 4, 2022
View reviewed changes
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/self-metrics-response-code branch from 84b99a5 to 0a71b33 Compare August 4, 2022 18:29
@ridwanmsharif ridwanmsharif added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 4, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 4, 2022
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/self-metrics-response-code branch from 0a71b33 to 7d68789 Compare August 5, 2022 14:52
@ridwanmsharif ridwanmsharif added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 5, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 5, 2022
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/self-metrics-response-code branch from 7d68789 to 19d1177 Compare August 8, 2022 19:07
@ridwanmsharif ridwanmsharif added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 8, 2022
@ridwanmsharif
confgenerator: preserve response_code for agent self metrics
6b57fbe 
This change preserves the `response_code` label on self metrics where
appropriate. See the [spec](https://cloud.google.com/monitoring/api/metrics_opsagent#agent-agent) for more details.

Note: This requires a change in Fluent Bit befoe merging. See
fluent/fluent-bit#5836 for more details.

Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/self-metrics-response-code branch from 19d1177 to 6b57fbe Compare August 9, 2022 15:38
@ridwanmsharif ridwanmsharif merged commit 724f61b into master Aug 9, 2022
@igorpeshansky igorpeshansky deleted the ridwanmsharif/self-metrics-response-code branch July 10, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaelwestphal rafaelwestphal rafaelwestphal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ridwanmsharif @rafaelwestphal @stackdriver-instrumentation-release