out_stackdriver: add name label to the metrics emitted #5836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridwanmsharif
added a commit
to ridwanmsharif/fluent-bit
that referenced
this pull request
Aug 4, 2022
This change adds the `name` label to the metrics. When used with multiple of the same exporter, the metrics from each of them become indistinguishable from the others. This leads to problems when ingesting metrics. For example the `prometheus` receiver in Open Telemetry will assume they are one and the same metric and will replace existing data points with later ones. Backport PR of fluent#5836 Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif
added a commit
to GoogleCloudPlatform/ops-agent
that referenced
this pull request
Aug 9, 2022
This change preserves the `response_code` label on self metrics where appropriate. See the [spec](https://cloud.google.com/monitoring/api/metrics_opsagent#agent-agent) for more details. Note: This requires a change in Fluent Bit befoe merging. See fluent/fluent-bit#5836 for more details. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif
added a commit
to GoogleCloudPlatform/ops-agent
that referenced
this pull request
Aug 9, 2022
This change preserves the `response_code` label on self metrics where appropriate. See the [spec](https://cloud.google.com/monitoring/api/metrics_opsagent#agent-agent) for more details. Note: This requires a change in Fluent Bit befoe merging. See fluent/fluent-bit#5836 for more details. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
|
please sign-off your commits to pass the DCO error @qingling128 @igorpeshansky pls let us know if this is ok to go |
ridwanmsharif
added a commit
to ridwanmsharif/fluent-bit
that referenced
this pull request
Aug 15, 2022
This change adds the `name` label to the metrics. When used with multiple of the same exporter, the metrics from each of them become indistinguishable from the others. This leads to problems when ingesting metrics. For example the `prometheus` receiver in Open Telemetry will assume they are one and the same metric and will replace existing data points with later ones. Backport PR of fluent#5836 Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
This change adds the `name` label to the metrics. When used with multiple of the same exporter, the metrics from each of them become indistinguishable from the others. This leads to problems when ingesting metrics. FOr example the `prometheus` reciever in Open Telemetry will assume they are one and the same metric nad will replace existing data points with later ones. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
12eb5a8 to
47273a3
Compare
ridwanmsharif
added a commit
to ridwanmsharif/fluent-bit
that referenced
this pull request
Aug 17, 2022
This change adds the `name` label to the metrics. When used with multiple of the same exporter, the metrics from each of them become indistinguishable from the others. This leads to problems when ingesting metrics. For example the `prometheus` receiver in Open Telemetry will assume they are one and the same metric and will replace existing data points with later ones. Backport PR of fluent#5836 Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
edsiper
pushed a commit
that referenced
this pull request
Aug 18, 2022
This change adds the `name` label to the metrics. When used with multiple of the same exporter, the metrics from each of them become indistinguishable from the others. This leads to problems when ingesting metrics. For example the `prometheus` receiver in Open Telemetry will assume they are one and the same metric and will replace existing data points with later ones. Backport PR of #5836 Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
namelabel to the metrics. When used with multipleof the same exporter, the metrics from each of them become
indistinguishable from the others. This leads to problems when ingesting
metrics. For example the
prometheusreceiver in Open Telemetry willassume they are one and the same metric and will replace existing data
points with later ones.
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.