Skip to content

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Oct 25, 2022

Description

git diff origin/master will include all the diffs from all PRs merged into the remote master since your PR was forked off of master. https://stackoverflow.com/a/65166745 explains that we should be using three dots instead of two dots (which is what git diff origin/master is doing under the hood), and when we do that, I don't think it makes a difference whether we use local master or origin/master, so I just picked local master for no particular reason.

Related issue

b/254325901

How has this been tested?

I noticed that git diff origin/master was giving me polluted diffs. I messed around with git commands on my workstation to confirm that the new command is doing what I think it is doing. I also checked two things in the context of Kokoro:

  1. I checked that the diffs look right for this PR (just third_party_apps_test.go)
  2. I waited for a different PR to be merged into master, then reran tests without merging from master and checked that the diffs are again just third_party_apps_test.go and didn't include any diffs introduced by master moving ahead.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 27, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 27, 2022
@martijnvans martijnvans requested a review from stati0n October 27, 2022 17:07
@martijnvans martijnvans merged commit 301b603 into master Oct 28, 2022
@martijnvans martijnvans deleted the martijnvans-fix-git-diff branch October 28, 2022 14:28
martijnvans added a commit that referenced this pull request Oct 31, 2022
martijnvans added a commit that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants