Testing: Fix git diff command to produce cleaner diffs
#926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
git diff origin/masterwill include all the diffs from all PRs merged into the remote master since your PR was forked off of master. https://stackoverflow.com/a/65166745 explains that we should be using three dots instead of two dots (which is whatgit diff origin/masteris doing under the hood), and when we do that, I don't think it makes a difference whether we use local master or origin/master, so I just picked local master for no particular reason.Related issue
b/254325901
How has this been tested?
I noticed that
git diff origin/masterwas giving me polluted diffs. I messed around with git commands on my workstation to confirm that the new command is doing what I think it is doing. I also checked two things in the context of Kokoro:third_party_apps_test.go)third_party_apps_test.goand didn't include any diffs introduced by master moving ahead.Checklist: