Skip to content

Revert "Testing: Fix git diff command to produce cleaner diffs" #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2022
Merged

Revert "Testing: Fix git diff command to produce cleaner diffs" #933

merged 2 commits into from
Oct 31, 2022

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Oct 31, 2022 •
edited
Loading

Reverts #926 due to issues with the release build. Reproduced locally, the error is:

fatal: ambiguous argument 'master...': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

My guess is that this is because kokoro clones with --depth=1, so it doesn't have the info needed to compute git diff master...

@martijnvans martijnvans requested review from a team, jefferbrecht and ridwanmsharif and removed request for a team and ridwanmsharif October 31, 2022 15:13
@martijnvans martijnvans merged commit c959926 into master Oct 31, 2022
@martijnvans martijnvans deleted the revert-926-martijnvans-fix-git-diff branch October 31, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jefferbrecht jefferbrecht jefferbrecht approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martijnvans @jefferbrecht