Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Package identities, provenance, and dependency locks are consistent, with unchanged canonical parser sources and no blocking issues identified.
No open issues 🎉
What changed in this PR
Pins LithoSharp’s Syntamark runtime/source pair to the main-produced 1.0.0 release while preserving parser behavior.
Changes:
- Updates the shared Syntamark version to 1.0.0.
- Refreshes source provenance and artifact hashes.
- Aligns 18 dependency lockfiles with the selected packages and project versions.
| File | Description |
|---|---|
| tests/LithoSharp.Tests/packages.lock.json | Updates runtime and project dependency locks. |
| tests/LithoSharp.Markdown.PortableHost/packages.lock.json | Pins source package 1.0.0. |
| tests/LithoSharp.Markdown.Portability/packages.lock.json | Updates runtime dependency lock. |
| tests/LithoSharp.MarkdigComparison/packages.lock.json | Updates runtime dependency lock. |
| tests/LithoSharp.LanguageServer.Tests/packages.lock.json | Updates runtime and project dependency locks. |
| src/LithoSharp/packages.lock.json | Pins runtime package 1.0.0. |
| src/LithoSharp.Tool/packages.lock.json | Updates runtime and project dependency locks. |
| src/LithoSharp.Testing/packages.lock.json | Updates runtime dependency lock. |
| src/LithoSharp.Mdx/packages.lock.json | Updates runtime dependency lock. |
| src/LithoSharp.LanguageServer/packages.lock.json | Updates runtime and project dependency locks. |
| src/LithoSharp.Images/packages.lock.json | Updates runtime dependency lock. |
| src/LithoSharp.Generators/packages.lock.json | Pins source package 1.0.0. |
| src/LithoSharp.Analyzers/packages.lock.json | Pins source package 1.0.0. |
| samples/LithoSharp.Sample/packages.lock.json | Updates sample runtime lock. |
| samples/LithoSharp.MdxSample/packages.lock.json | Updates runtime and project dependency locks. |
| samples/LithoSharp.DocsSample/packages.lock.json | Updates runtime and project dependency locks. |
| eng/markdown/component-pair.json | Records main-commit provenance and artifact hashes. |
| Directory.Build.props | Sets shared Syntamark version to 1.0.0. |
| benchmarks/LithoSharp.Performance/packages.lock.json | Updates benchmark runtime lock. |
| benchmarks/LithoSharp.MdxPerformance/packages.lock.json | Updates runtime and project dependency locks. |
Review effort: Balanced
|
The formal Syntamark pin in this PR is unchanged and is included in #62. Its Windows CI exposed a test-side file sharing race, while the earlier #62 head exposed a separate lazy-worker warmup error after cache recovery. #62 now targets main with both corrections; only its repaired, fully green head will be eligible for integration. No failed check is being bypassed. |
|
Superseded by #62, normally squash-merged as c667edb after complete green three-OS builds and same-VSIX installed-extension acceptance. All 22 files from verified pin commit da2baf3 are byte-identical on main. The Windows sharing race exposed by this PR was fixed without weakening production file sharing. No failed checks were bypassed. Exact final-main CI is now required before any release tag; performance latency issues remain open. |
Summary
Pin the Syntamark 1.0.0 runtime/source pair generated from merged Syntamark main commit
04729694c11c9c16f8a734b6c78eb46303504bdc, rather than the earlier feature-branch candidate. Update the fixed feed, provenance manifest and affected dependency locks without changing parser behavior.Producer: https://github.com/Htkym/syntamark/actions/runs/39026743742
Publication: https://github.com/Htkym/syntamark/actions/runs/39028068876
Manifest SHA256:
3b54151f0deac33bef2c93b6f91276df8580a31e81935471e5f43ccfe47bddc6Validation:
node eng\markdown\Verify-FixedPair.mjs verify-fixed eng\markdown\feed— passed.dotnet restore LithoSharp.slnx --locked-mode— passed with an isolated package cache.dotnet build LithoSharp.slnx --no-restore -c Release --verbosity minimal— passed; 676 existing XML-documentation warnings.dotnet test --project tests\LithoSharp.Tests\LithoSharp.Tests.csproj --no-build --no-restore -c Release -- --treenode-filter "/*/*/Markdown*/*"— passed, 65 tests.dotnet run --project tests\LithoSharp.Markdown.Artifacts -c Release --no-build --no-restore -p:SyntamarkArtifactVersion=1.0.0 -- eng\markdown\component-pair.json src\LithoSharp.Generators\bin\Release\netstandard2.0\LithoSharp.Generators.dll <local-result.json>— passed: runtime/source facts and dependency identity agree; mismatched stamps are rejected.dotnet run --project samples\LithoSharp.DocsSample -c Release --no-build --no-restore -- --output .local\stable-docs-site— passed.dotnet run --project samples\LithoSharp.Sample -c Release --no-build --no-restore -- --output .local\stable-blog-site— passed.The full solution test suite and installed-extension matrix are left to this PR's normal CI. The separate Windows MDX watcher failure on the preceding main run is under investigation and is not claimed fixed by this dependency update.
Related issues
Coordinated Syntamark 1.0.0 / LithoSharp 2.0.0 / SharpDeps 0.2.0 release.
Checklist
dotnet build LithoSharp.slnx -c Releasesucceedsdotnet test --solution LithoSharp.slnx -c Releasepassesdotnet run --project samples/LithoSharp.DocsSample -- --output _sitedotnet run --project samples/LithoSharp.Sample -- --output _sitepackages.lock.jsonupdated if dependencies changedGenerated output
No change. The parser's canonical source hash, contract and dialect profile are unchanged. The formal package identity and source-commit provenance are updated together.