sleep state - run idle scripts and allow to control the backlight - #582
Merged
Merged
Conversation
fvanroie
approved these changes
Nov 29, 2023
fvanroie
requested changes
Nov 29, 2023
fvanroie
left a comment
Collaborator
There was a problem hiding this comment.
This can already be accomplished with idle scripts.
perexg
force-pushed
the
topic/idle-scripts
branch
from
November 29, 2023 19:42
12bd214 to
e092b72
Compare
Contributor
Author
|
As you like, but I think that this is really common settings, so it belongs to the http config ui. Removed the second patch, let me know, if you like to do a separate PR for the second one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idle scripts are not executed when the sleep state changes based on the system timer. Make things consistent.
EDIT: Added second patch to allow set the dimming values per idle states using web server.