Repository navigation
fix: remove obsolete iframe attributes from bilibili shortcode - #1612
Merged
Merged
Conversation
- Remove scrolling, border, frameborder, framespacing (obsolete attrs) - Change allowfullscreen="true" to boolean allowfullscreen The .bilibili iframe CSS already handles sizing and appearance. Fixes 40 W3C validation errors/warnings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrolling,border,frameborder,framespacingattributes from the bilibili<iframe>(10 errors + 30 warnings)allowfullscreen="true"→ booleanallowfullscreen(10 errors).bilibili iframeCSS already handles sizing/appearance, so no visual changeTest plan
npm run validate— bilibili iframe errors/warnings should be goneCloses part of #1498
🤖 Generated with Claude Code