Repository navigation
fix(webui): support WSL browser launch and clearer startup output - #6150
Open
chengyongru wants to merge 13 commits into
Open
chengyongru wants to merge 13 commits into
chengyongru wants to merge 13 commits into
Conversation
Keep generated local credentials and provide the full browser login link in every launch mode. Require a chosen password when enabling network access, preserve existing authentication, and show pending listener changes until restart. Remove mandatory first-run initialization gates and simplify startup output while retaining gateway warnings and errors.
chengyongru
force-pushed
the
feat/webui-first-run-access
branch
from
October 10, 2026 20:39
af5bd76 to
b5e2605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WSL, opening WebUI could fall through to a Linux browser launcher that cannot reach the Windows desktop. The launcher now opens the Windows default browser through the inbox Windows PowerShell, while respecting an explicit
BROWSERsetting and--no-open. The existing authenticated launch URL travels through stdin and a private temporary redirect file, keeping credentials out of process arguments. The helper owns file cleanup independently of the calling CLI.Startup output now groups readiness, the complete copyable login link, model setup guidance, config, logs, and exit controls with blank lines and distinct colors. A fresh installation gets one setup confirmation and a direct Settings → Models next step without an unexplained default model error. Gateway warnings and errors remain visible; routine logs and the Vite banner no longer crowd the startup summary. Browser-launch failure points to the printed link. The launcher shares one lease and dev-server cleanup flow for new and existing gateways, preserving external gateway ownership.
This PR is limited to WSL browser opening and startup output. WebUI pages, authentication policy, password generation, network-access configuration, and TUI code match the PR base. No access toggle, password-setting flow, or password-policy change is included.
Related to NAN-238.
Validation:
--dev,--no-open, and dev + no-open. Ordinary and dev opened the actual Windows default browser and reached the authenticated workbench; no-open modes created no browser tab. Startup output was checked at 48 columns for complete links, spacing, colors, and setup guidance.git diff --checkpassed. Test gateways, temporary configurations, browser sessions, and ports were cleaned up. Current PR checks.Windows desktop evidence is from WSL with the Windows default browser and a separate Windows headless Chrome session. Standalone Windows Python and macOS desktop launches were not rerun locally. The first dev-browser observation timed out at 20 seconds; the unchanged code passed a second run with a 40-second observation window.