Add std_shards_args and update creator for crystal - #23790
Merged
Merged
Conversation
cho-m
force-pushed
the
formula_creator-crystal
branch
from
September 4, 2026 22:34
9e6912b to
e512719
Compare
cho-m
force-pushed
the
formula_creator-crystal
branch
from
September 4, 2026 23:03
e512719 to
5bcc175
Compare
cho-m
force-pushed
the
formula_creator-crystal
branch
from
September 4, 2026 23:51
5bcc175 to
600f53b
Compare
Refactor expectation for default arguments Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
cho-m
force-pushed
the
formula_creator-crystal
branch
from
September 5, 2026 00:19
8ae8d1a to
b41be79
Compare
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The implementation matches current Shards semantics and includes focused coverage for both helper and template behavior.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing out arguments in
deny_network_access!and fetch聽homebrew-core#301831As far as I can tell
shards installmainly downloads/unpacks deps whileshards builddoes the actual compilation.Arguments for fetch include:
--productionto require shards.lock and exclude dev dependencies, which is similar to defaults we use elsewhere.--skip-postinstallfor similar security preference as npm. Can be removed if upstream drops support for these:https://github.com/crystal-lang/shards/issues/700Also align the build arguments with most common set we use in core formulae, i.e.
--productionis same as above and makes sure dependency resolution is the same--no-debugis crystal argument to avoid debug symbols.Ref: https://github.com/crystal-lang/shards/blob/master/docs/shards.adoc#commands
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?