Skip to content

Add std_shards_args and update creator for crystal - #23790

Merged
MikeMcQuaid merged 2 commits into
mainfrom
formula_creator-crystal
Sep 5, 2026
Merged

MikeMcQuaid merged 2 commits into
mainfrom
formula_creator-crystal

Conversation

@cho-m

@cho-m cho-m commented Sep 4, 2026

Copy link
Copy Markdown
Member

Testing out arguments in

As far as I can tell shards install mainly downloads/unpacks deps while shards build does the actual compilation.

Arguments for fetch include:

  • --production to require shards.lock and exclude dev dependencies, which is similar to defaults we use elsewhere.
  • --skip-postinstall for similar security preference as npm. Can be removed if upstream drops support for these: https://github.com/crystal-lang/shards/issues/700

Also align the build arguments with most common set we use in core formulae, i.e.

  • --production is same as above and makes sure dependency resolution is the same
  • --no-debug is crystal argument to avoid debug symbols.

Ref: https://github.com/crystal-lang/shards/blob/master/docs/shards.adoc#commands


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Copilot AI balanced review requested due to automatic review settings September 4, 2026 22:10

This comment was marked as outdated.

@cho-m
cho-m force-pushed the formula_creator-crystal branch from 9e6912b to e512719 Compare September 4, 2026 22:34
@cho-m
cho-m requested a balanced review from Copilot September 4, 2026 22:34

This comment was marked as outdated.

@cho-m
cho-m force-pushed the formula_creator-crystal branch from e512719 to 5bcc175 Compare September 4, 2026 23:03
@cho-m
cho-m requested a balanced review from Copilot September 4, 2026 23:03

This comment was marked as resolved.

@cho-m
cho-m force-pushed the formula_creator-crystal branch from 5bcc175 to 600f53b Compare September 4, 2026 23:51
@cho-m cho-m changed the title formula_creator: add deny network for crystal Add std_shards_args and update creator for crystal Sep 4, 2026
@cho-m
cho-m requested a balanced review from Copilot September 4, 2026 23:52

This comment was marked as outdated.

Refactor expectation for default arguments

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@cho-m
cho-m force-pushed the formula_creator-crystal branch from 8ae8d1a to b41be79 Compare September 5, 2026 00:19
@cho-m
cho-m requested a balanced review from Copilot September 5, 2026 00:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煝 Approval recommended

The implementation matches current Shards semantics and includes focused coverage for both helper and template behavior.

Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 5, 2026
Merged via the queue into main with commit ede34b0 Sep 5, 2026
54 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the formula_creator-crystal branch September 5, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants