Narrow mkdir_p sandbox write permissions - #23897
Merged
Merged
Conversation
- Avoid granting writes beside a `mkdir_p` target when its parent already exists. - Preserve the parent allowance when directory creation needs it.
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
Linux Landlock path preparation can alter guard results and prevent guarded steps from running.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Narrows sandbox permissions for mkdir_p while retaining parent access when required.
Changes:
- Selects the target or parent based on parent existence.
- Updates tests and Cask documentation.
File summaries
| File | Description |
|---|---|
Library/Homebrew/install_steps.rb |
Adjusts sandbox write paths. |
Library/Homebrew/test/install_steps_spec.rb |
Updates expected permissions. |
docs/Cask-Cookbook.md |
Documents permission behaviour. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
krehel
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkdir_ptarget when its parent already exists.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at High effort, with local review and testing.