Skip to content

cask: add pwsh_completion stanza - #24046

Merged
MikeMcQuaid merged 2 commits into
Homebrew:mainfrom
AlternateRT:cask-pwsh-completion-stanza
Sep 21, 2026
Merged

MikeMcQuaid merged 2 commits into
Homebrew:mainfrom
AlternateRT:cask-pwsh-completion-stanza

Conversation

@AlternateRT

Copy link
Copy Markdown
Contributor

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

The cask DSL was missing a pwsh_completion stanza; this adds it to better align it with the formula DSL.

I would also like to propose reordering the existing shell completion stanzas to:

bash_completion
zsh_completion
fish_completion

Homebrew's documentation uses this order in multiple places, e.g. Shell Completions generate_completions_from_executable. There is no enforced sort order on formulae, but from what I've seen, most sort them like this already.

This would affect 9 casks. This PR includes a workaround for the sort cop so that we can transition them to the proposed order.

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Few small notes.

Comment thread Library/Homebrew/rubocops/cask/stanza_order.rb Outdated
@AlternateRT
AlternateRT force-pushed the cask-pwsh-completion-stanza branch from c8b6a42 to 5ac888d Compare September 20, 2026 18:02

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 21, 2026
Merged via the queue into Homebrew:main with commit bef6710 Sep 21, 2026
52 checks passed
@AlternateRT
AlternateRT deleted the cask-pwsh-completion-stanza branch September 21, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants