Skip to content

pkg: run Git as the installation user - #24019

Merged
MikeMcQuaid merged 1 commit into
mainfrom
pkg-git-install-user
Sep 17, 2026
Merged

pkg: run Git as the installation user#24019
MikeMcQuaid merged 1 commit into
mainfrom
pkg-git-install-user

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Sep 17, 2026

Copy link
Copy Markdown
Member
  • Run repository Git commands and any programs they launch as the selected installation user.
  • Set ownership before Git runs and require a non-root account.
  • Use a system PATH and omit the user's global Git configuration.
  • Check command dispatch and root user rejection in tests.
  • Document installation ownership and when packages need sudo.
  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?
  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at Extra High effort, with local review and testing.

@MikeMcQuaid
pkg: run Git as the installation user
3a856d2 
- Run repository Git commands and any programs they launch as the
  selected installation user.
- Set ownership before Git runs and require a non-root account.
- Use a system `PATH` and omit the user's global Git configuration.
- Check command dispatch and root user rejection in tests.
- Document installation ownership and when packages need `sudo`.
@MikeMcQuaid
MikeMcQuaid requested a review from a team as a code owner September 17, 2026 13:06
Copilot AI lite review requested due to automatic review settings September 17, 2026 13:06
Copilot AI reviewed Sep 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit cd140fb Sep 17, 2026
56 of 57 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the pkg-git-install-user branch September 17, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeMcQuaid @p-linnane