[frontend/auth_methods] Allow auth methods to prevent user deletion - #1175
Open
anthonygego wants to merge 1 commit into
Open
anthonygego wants to merge 1 commit into
anthonygego wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 8 |
| Duplication | 4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
nrybowski
self-requested a review
September 17, 2026 10:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs is a first step to allow both private and public usage on the same instance. It allows SAML and LDAP authentication methods (it is not relevant to social platform) to prevent the binding removal.
User deletion is then aborted if any of the bound auth methods prevents removal and invites user to contact the platform administrator.
Concretely, it is just an additional
allow_removalin the auth method config.I removed the optional argument from the
UserManager.delete.usermethod and added typing hints but I realise there are still a lot of bad smells there that I think are out of the scope of this PR.