[user_manager/user_info] refactor get_users_info and UserInfo - #1179
Open
anthonygego wants to merge 1 commit into
Open
anthonygego wants to merge 1 commit into
anthonygego wants to merge 1 commit into
Conversation
Also fix missing None in case users are not found Closes #1177 Co-authored-by: Tor Andre Haugdahl <thaugdahl@gmail.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
nrybowski
self-requested a review
September 17, 2026 10:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue reported in #1177 and provides a first refactor
UserManager.get_users_info.get_users_infowas actually used in two cases with different signatures (usernamesorlimit, skipactually used)None.UserInfowas a redundant data structure since mongoengine migration. Removed it and returnedUsermodel directly. Adapted code.I recall this was introduced to limit the risk of exposing the raw dictionary with confidential data in templates, but mongoengine does not allow to dump the whole model values implicitly, so the requirements are kept.