fix(frontend): prevent signup header from sticking to top edge - #7165
Merged
Merged
Conversation
The signup page's tall content (OAuth buttons + email form) overflows the max-h-screen scroll container, causing the header — logo and top-right "Log In" button — to scroll flush against the top edge. Add py-4 to the scroll container so the header keeps a top inset that matches its horizontal padding, even when content overflows. The login page is unaffected as its shorter content does not overflow.
jal-co
marked this pull request as ready for review
July 5, 2026 20:04
Contributor
|
| Filename | Overview |
|---|---|
| frontend/src/pages/auth/SignUpPage/SignUpPage.tsx | Adds py-4 to the scroll container so vertical padding matches the existing horizontal px-4, preventing the header from sitting flush against the top edge on overflow. |
Reviews (1): Last reviewed commit: "fix(frontend): prevent signup header fro..." | Re-trigger Greptile
akhilmhdh
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #7166.
On the signup page, the content (OAuth buttons + email form) is tall enough to overflow the
max-h-screenscroll container. When it overflows, the header, the logo and the top-right "Log In" button scrolls flush against the very top edge of the page with no breathing room.This adds
py-4to the signup page's scroll container (frontend/src/pages/auth/SignUpPage/SignUpPage.tsx), matching its existingpx-4horizontal inset, so the header keeps a consistent top inset even when the content overflows. Scoped to the signup page only. The sharedAuthPageHeaderis untouched, so the login page (shorter content, no overflow) is unchanged.Screenshots
Before:
After:
Steps to verify the change
Type
Checklist
type(scope): short description