Skip to content

fix: resolved loosing invoice on losing sub - #8142

Merged
akhilmhdh merged 1 commit into
mainfrom
feat/missing-invoice
Sep 15, 2026
Merged

fix: resolved loosing invoice on losing sub#8142
akhilmhdh merged 1 commit into
mainfrom
feat/missing-invoice

Conversation

@akhilmhdh

@akhilmhdh akhilmhdh commented Sep 15, 2026

Copy link
Copy Markdown
Member

Context

This PR fixes a ui bug of loosing of the invoices, payment card detail update, profile update on loosing the subscription.

Screenshots

Steps to verify the change

  1. Cancel your sub through stripe or any path
  2. You should still be able to fetch your old invoices and update card as needed

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

@akhilmhdh
akhilmhdh requested a review from Thiago-AS September 15, 2026 20:35
@infisical-review-police

infisical-review-police Bot commented Sep 15, 2026

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-infisical-8142-fix-resolved-loosing-invoice-on-loosing-sub

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-15T20:39:39.266950Z 10657be PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@akhilmhdh akhilmhdh changed the title fix: resolved loosing invoice on loosing sub fix: resolved loosing invoice on losing sub Sep 15, 2026
@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

No blocking issue was established, though rendered behavior could not be exercised because the local validation page did not load its generated bundle.

What we checked:

  • The final attempted command to run the billing v2 harness for PR-8142 was issued. T-Rex
  • Chromium returned an unexecuted document because the harness loaded bundle.js through a file URL, creating a blocker until a local HTTP server or valid file-relative bundle path is used. T-Rex
  • Artifacts were prepared for review, including the generated harness bundle and the corresponding run log. T-Rex

Summary

T-Rex validation blocked

Rendered verification of the Billing V2 no-subscription states could not complete because the local harness loaded its generated bundle through a file URL that could not resolve the script path.

Summary

The change reuses the payment, billing-details, and invoice section for non-managed organizations with a canceled subscription and existing billing history. No blocking issue was established.

Reviews (1) · Last reviewed commit: "fix: resolved loosing invoice on loosing..."

@akhilmhdh
akhilmhdh merged commit befe495 into main Sep 15, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] approved these changes
@Thiago-AS Thiago-AS Awaiting requested review from Thiago-AS

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@akhilmhdh