Repository navigation
Dynamically choose versioned libcuda - #503
Conversation
Some systems don't have the libcuda.so -> symlink. However, don't want to break compatibility with systems having `libcuda.so` already.
Why not? |
Maybe I misunderstood your concern in #502, I thought you said we didn't want to just put in |
|
That's true, but it's better to add an if statement that checks for |
|
definitely better. Didn't know that was a thing. Would you suggest I modify the pull request with this, or do you think it could be done better (in which case I'll lay off) |
|
If you want to modify the PR, then please do :-) Alternatively, and more in line with your approach, we could do |
|
Updated, thanks for the help! |
|
Ah, didn't notice all the commits, should have squashed this. For future reference: please rebase small commits that fix-up stuff into a single functional one, to keep the git history clean (for easier bisection, etc). |
In reference to discussion on #502 , we don't necessarily want to always use
libcuda.so.1. Dynamically check iflibcudacan already be found usingLibdl, and if we don't find it then trylibcuda.so.1. If this doesn't exist an error will be thrown to the user, as previously was, except sayinglibcuda.so.1 not found.