Skip to content

Fixes for Windows - #518

Merged
maleadt merged 2 commits into
masterfrom
tb/windows
Oct 29, 2020
Merged

maleadt merged 2 commits into
masterfrom
tb/windows

Conversation

@maleadt

@maleadt maleadt commented Oct 29, 2020

Copy link
Copy Markdown
Member

No description provided.

Comment thread lib/nvml/NVML.jl
if isdir(nvsmi)
joinpath(nvsmi, "nvml.dll")
else
# let's just hope for the best

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah typical windows

@codecov

codecov Bot commented Oct 29, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #518 into master will decrease coverage by 0.03%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   80.52%   80.49%   -0.04%     
==========================================
  Files         166      166              
  Lines        8884     8889       +5     
==========================================
+ Hits         7154     7155       +1     
- Misses       1730     1734       +4     
Impacted Files Coverage Δ
lib/nvml/NVML.jl 50.00% <33.33%> (-50.00%) ⬇️
test/runtests.jl 50.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9465f3b...e686d28. Read the comment docs.

@maleadt
maleadt merged commit 2db3096 into master Oct 29, 2020
@maleadt
maleadt deleted the tb/windows branch October 29, 2020 19:23
@maleadt maleadt added the installation CUDA is easy to install, right? label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

installation CUDA is easy to install, right?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants