Skip to content

Sorting perf (again) - #845

Merged
maleadt merged 1 commit into
JuliaGPU:masterfrom
xaellison:ae/bitonic_median
Apr 19, 2021
Merged

maleadt merged 1 commit into
JuliaGPU:masterfrom
xaellison:ae/bitonic_median

Conversation

@xaellison

Copy link
Copy Markdown
Contributor

Use bitonic sort for median selection instead of brick/bubble sort.
Sync logic changed to fix non-deterministic bug in multidimensional arrays where sort wasn't correct (but values weren't lost).

sync logic changed to fix non-deterministic bug in multidimensional arrays where values weren't lost but sort wasn't correct
@xaellison

Copy link
Copy Markdown
Contributor Author

Sorting tests passed everywhere. There was a failure of device/random. @maleadt do you think this failure is unrelated to my changes / have you seen this before?

@maleadt maleadt added cuda array Stuff about CuArray. performance How fast can we go? labels Apr 19, 2021
@maleadt

maleadt commented Apr 19, 2021

Copy link
Copy Markdown
Member

That failure was unrelated. Thanks!

@maleadt
maleadt merged commit 445081c into JuliaGPU:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda array Stuff about CuArray. performance How fast can we go?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants