Skip to content

support transpose CSC to CUDA CSR - #1132

Merged
maleadt merged 3 commits into
JuliaGPU:masterfrom
Roger-luo:roger/transpose-csc-cuda
Sep 22, 2021
Merged

maleadt merged 3 commits into
JuliaGPU:masterfrom
Roger-luo:roger/transpose-csc-cuda

Conversation

@Roger-luo

Copy link
Copy Markdown
Contributor

since Julia doesn't have a native CSR format, the transposed CSC is usually used as the CSR format, this avoids some extra allocation on GPU

@maleadt

maleadt commented Sep 7, 2021

Copy link
Copy Markdown
Member

LGTM. Maybe add a test?

@maleadt maleadt added cuda libraries Stuff about CUDA library wrappers. enhancement New feature or request needs tests Tests are requested. labels Sep 7, 2021
@Roger-luo

Copy link
Copy Markdown
Contributor Author

failed test looks irrelavent? I didn't change anything in cublas. Want me to rebase master on this PR too?

@maleadt
maleadt force-pushed the roger/transpose-csc-cuda branch from 8bc9d3e to 746d433 Compare September 20, 2021 11:41
@maleadt

maleadt commented Sep 20, 2021

Copy link
Copy Markdown
Member

Rebased.

@Roger-luo

Copy link
Copy Markdown
Contributor Author

it seems the julia 1.6 debug test fail because out of GPU memory, maybe this PR would be good to merge?

@maleadt
maleadt merged commit 28d4ab7 into JuliaGPU:master Sep 22, 2021
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda libraries Stuff about CUDA library wrappers. enhancement New feature or request needs tests Tests are requested.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants