Repository navigation
Switch contexts before performing memory operations on arrays - #1176
Merged
Merged
Conversation
maleadt
force-pushed
the
tb/context_switch
branch
from
October 1, 2021 15:57
e65ec7d to
cda026f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1176 +/- ##
==========================================
+ Coverage 79.77% 79.79% +0.01%
==========================================
Files 119 119
Lines 8239 8266 +27
==========================================
+ Hits 6573 6596 +23
- Misses 1666 1670 +4
Continue to review full report at Codecov.
|
This was referenced Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1175, which was caused by the REPL task still being on a different device.
Note that this just switches devices to avoid illegal memory accesses, there may still be synchronization issues (i.e. you still need to synchronize the correct stream before reading from GPU memory).
Also includes specialized copy functions for unified memory, where we don't need to switch contexts, and where we can just
memcpyon the CPU.