Skip to content

Import factorisation internal types from LinearAlgebra - #1558

Merged
maleadt merged 2 commits into
JuliaGPU:masterfrom
theabhirath:qrcompactwy
Jul 6, 2022
Merged

maleadt merged 2 commits into
JuliaGPU:masterfrom
theabhirath:qrcompactwy

Conversation

@theabhirath

Copy link
Copy Markdown
Contributor

This was previously causing a precompilation error on Julia master because it wasn't explicitly imported:

ERROR: LoadError: UndefVarError: QRCompactWY not defined
Stacktrace:
  [1] top-level scope
    @ ~/.julia/packages/CUDA/tTK8Y/lib/cusolver/linalg.jl:83
  [2] include(mod::Module, _path::String)
    @ Base ./Base.jl:422
  [3] include(x::String)
    @ CUDA.CUSOLVER ~/.julia/packages/CUDA/tTK8Y/lib/cusolver/CUSOLVER.jl:1
  [4] top-level scope
    @ ~/.julia/packages/CUDA/tTK8Y/lib/cusolver/CUSOLVER.jl:27
  [5] include(mod::Module, _path::String)
    @ Base ./Base.jl:422
  [6] include(x::String)
    @ CUDA ~/.julia/packages/CUDA/tTK8Y/src/CUDA.jl:1
  [7] top-level scope
    @ ~/.julia/packages/CUDA/tTK8Y/src/CUDA.jl:99
  [8] include
    @ ./Base.jl:422 [inlined]
  [9] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt64}}, source::String)
    @ Base ./loading.jl:1614
 [10] top-level scope
    @ stdin:1

@maleadt

maleadt commented Jul 6, 2022

Copy link
Copy Markdown
Member

Ref JuliaLang/julia#45935

@maleadt maleadt added the bugfix This gets something working again. label Jul 6, 2022
@maleadt

maleadt commented Jul 6, 2022

Copy link
Copy Markdown
Member

There's more:

ERROR: LoadError: UndefVarError: QRPackedQ not defined

@theabhirath

Copy link
Copy Markdown
Contributor Author

Think I got them all this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This gets something working again.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants