Skip to content

Upgrade CUSTATEVEC to v1.1 - #1638

Merged
maleadt merged 3 commits into
masterfrom
tb/custatevec
Oct 24, 2022
Merged

Upgrade CUSTATEVEC to v1.1#1638
maleadt merged 3 commits into
masterfrom
tb/custatevec

Conversation

@maleadt

@maleadt maleadt commented Oct 21, 2022

Copy link
Copy Markdown
Member

Taken from #1623; with the JLL refactor we can now upgrade sublibraries separately.

@kshyatt although on this PR all tests work, I also added support for the new logging capabilities, and enabling them (by running tests under JULIA_DEBUG=CUSTATEVEC) I'm noticing several errors:

┌ Error: custatevecSamplerPreprocess: Invalid sampler is passed to custatevecSamplerPreprocess.
└ @ CUSTATEVEC ~/Julia/pkg/CUDA/lib/custatevec/src/CUSTATEVEC.jl:100

┌ Error: custatevecSamplerSample: sampler is not initialized in custatevecSamplerSample.
└ @ CUSTATEVEC ~/Julia/pkg/CUDA/lib/custatevec/src/CUSTATEVEC.jl:100

Could you take a look at those?

@maleadt maleadt added the cuda libraries Stuff about CUDA library wrappers. label Oct 21, 2022
@maleadt maleadt changed the title Upgrade CUSTATEVEC to v1.10 Upgrade CUSTATEVEC to v1.1 Oct 21, 2022
@maleadt maleadt mentioned this pull request Oct 21, 2022
Closed
@codecov

codecov Bot commented Oct 22, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 61.56% // Head: 60.91% // Decreases project coverage by -0.65% ⚠️

Coverage data is based on head (4ded258) compared to base (3d1670c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1638      +/-   ##
==========================================
- Coverage   61.56%   60.91%   -0.66%     
==========================================
  Files         151      151              
  Lines       11340    11397      +57     
==========================================
- Hits         6982     6943      -39     
- Misses       4358     4454      +96
Impacted Files Coverage Δ
lib/custatevec/src/CUSTATEVEC.jl 0.00% <0.00%> (ø)
lib/custatevec/src/error.jl 0.00% <0.00%> (ø)
lib/custatevec/src/libcustatevec.jl 0.00% <0.00%> (ø)
lib/custatevec/src/statevec.jl 0.00% <0.00%> (ø)
lib/custatevec/src/types.jl 0.00% <0.00%> (ø)
lib/cublas/CUBLAS.jl 52.63% <0.00%> (-23.69%) ⬇️
src/utilities.jl 67.10% <0.00%> (-9.22%) ⬇️
lib/cudadrv/module/linker.jl 68.75% <0.00%> (-3.13%) ⬇️
lib/cudadrv/memory.jl 78.59% <0.00%> (-1.01%) ⬇️
src/array.jl 82.30% <0.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kshyatt

kshyatt commented Oct 23, 2022

Copy link
Copy Markdown
Member

Yeah can do

@kshyatt

kshyatt commented Oct 23, 2022

Copy link
Copy Markdown
Member

I'm able to repro the logging issue

@kshyatt

kshyatt commented Oct 23, 2022

Copy link
Copy Markdown
Member

Should be fixed now

maleadt
maleadt commented Oct 23, 2022
View reviewed changes
Comment thread test/Project.toml Outdated
maleadt
maleadt commented Oct 24, 2022
View reviewed changes

@maleadt maleadt left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maleadt
maleadt merged commit bd25557 into master Oct 24, 2022
@maleadt
maleadt deleted the tb/custatevec branch October 24, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kshyatt kshyatt kshyatt left review comments

Assignees

@kshyatt kshyatt

Labels

cuda libraries Stuff about CUDA library wrappers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maleadt @kshyatt