Skip to content

[CUSPARSE] Interface color reordering - #1794

Merged
maleadt merged 3 commits into
JuliaGPU:masterfrom
amontoison:cusparse_color
Mar 15, 2023
Merged

maleadt merged 3 commits into
JuliaGPU:masterfrom
amontoison:cusparse_color

Conversation

@amontoison

Copy link
Copy Markdown
Member

A routine relevant to call before the computation of ILU(0) and IC(0) preconditioners.
I use it for my research.

index is an optional argument. It could also be a keyword argument.
I don't know what is the best option.

@maleadt maleadt added the cuda libraries Stuff about CUDA library wrappers. label Mar 13, 2023
@maleadt

maleadt commented Mar 13, 2023

Copy link
Copy Markdown
Member

index is an optional argument. It could also be a keyword argument.
I don't know what is the best option.

We currently almost never have default arguments, or keyword arguments, to these kind of low-level wrappers. Not saying we shouldn't, but maybe for consistency at least for now keep index a positional arg without a default value.

I guess that in the context of Julia wrappers it would make sense to move all index args in our wrappers to be a kwarg with default value 'O' though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda libraries Stuff about CUDA library wrappers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants