Repository navigation
Add the structures ILU0Info() and IC0Info() for the preconditioners - #2187
Merged
Merged
Conversation
maleadt
reviewed
Dec 5, 2023
Member
|
I wonder if we should introduce syntax for this, that would allow for automatic scoped destruction (a la
I'd prefer if we act consistently for all cases, if only to make it easier to refactor this code if e.g. switching to a Defer.jl-like mechanism. |
amontoison
force-pushed
the
helpers_ilu0_ic0
branch
from
December 5, 2023 13:56
a6033c9 to
5b0c412
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal structure that contains the
infoduring the computation of the preconditioner was not destroyed if a null pivot was encountered.For CSC / CSR formats, I added structures such that we don't take care of that.
For BSR format, I destroy the structure if a null pivot is encountered, I didn't added structures because we don't use often this format...