Repository navigation
Cached workspace prototype for custatevec - #2279
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2279 +/- ##
==========================================
+ Coverage 72.00% 72.02% +0.02%
==========================================
Files 155 155
Lines 14862 14881 +19
==========================================
+ Hits 10701 10718 +17
- Misses 4161 4163 +2 ☔ View full report in Codecov by Sentry. |
maleadt
approved these changes
Mar 4, 2024
maleadt
left a comment
Member
There was a problem hiding this comment.
This is probably something useful we could apply to other libraries too.
Member
Author
|
Fixed all except adding to |
maleadt
reviewed
Mar 11, 2024
Member
|
Alright, this looks nice. We could probably apply this pattern to more libraries, but let's merge this already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to attach a buffer to each library handle so we can re-use the buffers for many small calls to the same handle and avoid thrashing GC.