Skip to content

Adapt to AddrSpacePtr rename. - #258

Merged
maleadt merged 6 commits into
masterfrom
tb/llvmptr_simple
Jul 1, 2020
Merged

maleadt merged 6 commits into
masterfrom
tb/llvmptr_simple

Conversation

@maleadt

@maleadt maleadt commented Jun 29, 2020 •

Copy link
Copy Markdown
Member

Simpler alternative to #199, which seems to break CUSPARSE...

@maleadt
maleadt force-pushed the tb/llvmptr_simple branch 3 times, most recently from d80cff9 to 3dbf30a Compare June 30, 2020 09:12
@maleadt
maleadt force-pushed the tb/llvmptr_simple branch from 3dbf30a to ed13edc Compare June 30, 2020 13:21
@maleadt
maleadt force-pushed the tb/llvmptr_simple branch from 3d515f5 to a44384b Compare July 1, 2020 10:15
@maleadt

maleadt commented Jul 1, 2020 •

Copy link
Copy Markdown
Member Author

I was seeing a bunch of sporadic INVALID_VALUE errors during plain memory copies, both here on CI and locally for a while now, when I read:

Memory regions requested must be either entirely registered with CUDA, or in the case of host pageable transfers, not registered at all. Memory regions spanning over allocations that are both registered and not registered with CUDA are not supported and will return CUDA_ERROR_INVALID_VALUE.

So I'm trying a revert of #233 here, since only @kshyatt is using that functionality and it was broken for her anyhow.

@codecov

codecov Bot commented Jul 1, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #258 into master will decrease coverage by 0.10%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   80.53%   80.42%   -0.11%     
==========================================
  Files         154      154              
  Lines       10114    10231     +117     
==========================================
+ Hits         8145     8228      +83     
- Misses       1969     2003      +34     
Impacted Files Coverage Δ
examples/wmma/high-level.jl 0.00% <ø> (-50.00%) ⬇️
examples/wmma/low-level.jl 0.00% <ø> (-50.00%) ⬇️
lib/cudadrv/memory.jl 84.15% <ø> (-1.71%) ⬇️
test/cusparse.jl 94.37% <ø> (+4.91%) ⬆️
test/device/wmma.jl 6.89% <15.38%> (-0.52%) ⬇️
test/runtests.jl 51.89% <25.00%> (-1.01%) ⬇️
test/cudadrv/memory.jl 100.00% <100.00%> (ø)
test/cusolver/cusparse.jl 95.20% <100.00%> (ø)
test/setup.jl 82.05% <100.00%> (+0.47%) ⬆️
lib/cudnn/softmax.jl 40.00% <0.00%> (-10.00%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58ddf7...8553584. Read the comment docs.

@vchuravy

vchuravy commented Jul 1, 2020

Copy link
Copy Markdown
Member

Urgh, so we can't do set's but have to register the whole object? We are using the pinning with KA because pinning the host memory is necessary for asynchronous memory transfers

@maleadt

maleadt commented Jul 1, 2020

Copy link
Copy Markdown
Member Author

I'm not sure what the exact limitations are, but it seems like this does cause issues so let's revert for now.

@maleadt
maleadt merged commit 5602eb9 into master Jul 1, 2020
@maleadt
maleadt deleted the tb/llvmptr_simple branch July 1, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants