Skip to content

Use a custom adaptor for cu so that adapt(CuArray) preserves element types. - #281

Merged
maleadt merged 2 commits into
masterfrom
tb/cu_adaptor
Jul 8, 2020
Merged

maleadt merged 2 commits into
masterfrom
tb/cu_adaptor

Conversation

@maleadt

@maleadt maleadt commented Jul 8, 2020

Copy link
Copy Markdown
Member

Fixes #278

@maleadt maleadt added the cuda array Stuff about CuArray. label Jul 8, 2020
@codecov

codecov Bot commented Jul 8, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #281 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   80.30%   80.30%           
=======================================
  Files         155      155           
  Lines       10260    10262    +2     
=======================================
+ Hits         8239     8241    +2     
  Misses       2021     2021           
Impacted Files Coverage Δ
test/array.jl 0.00% <ø> (ø)
test/cublas.jl 91.66% <ø> (ø)
test/nnlib.jl 0.00% <ø> (ø)
src/array.jl 91.09% <100.00%> (+0.09%) ⬆️
test/cudnn.jl 25.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c399bf...df4c6e8. Read the comment docs.

@maleadt
maleadt merged commit 027c0dc into master Jul 8, 2020
@maleadt
maleadt deleted the tb/cu_adaptor branch July 8, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda array Stuff about CuArray.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can we pleeeeeeeease make cu(x) eltype preserving?

1 participant