fix: ppsspp emulation #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 8ba2c72
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 0bb2b66
☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements cross-origin isolation headers across the application to enable SharedArrayBuffer and other features that require a secure context. The changes add middleware for setting COOP and COEP headers in multiple layers of the application stack, and updates Tauri dependencies to newer versions.
Key Changes
- Added cross-origin isolation middleware to the REST service that sets
Cross-Origin-Opener-Policy: same-originandCross-Origin-Embedder-Policy: credentiallessheaders - Implemented header injection for the Tauri webview launcher window and Vite development server
- Updated Tauri and related plugin dependencies to newer versions (2.8.x → 2.9.x)
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rest-service/src/middleware/mod.rs | Declares new middleware modules for cache control and cross-origin isolation |
| packages/rest-service/src/middleware/cross_origin_isolation.rs | Implements middleware to add cross-origin isolation headers to all responses |
| packages/rest-service/src/middleware/cache_control.rs | Implements middleware to add cache-control headers to all responses |
| packages/rest-service/src/lib.rs | Refactors service setup to use new middleware modules and removes inline response mapping |
| plugins/retrom-plugin-launcher/src/commands.rs | Adds header injection callback to webview window for emulator frame requests |
| packages/client-web/vite.config.ts | Adds Vite plugin to inject cross-origin isolation headers in dev and preview servers |
| packages/client/tauri.conf.json | Updates COEP header value (contains typo) |
| Cargo.toml | Updates Tauri and plugin dependencies to newer versions |
| Cargo.lock | Lock file updates reflecting dependency version changes |
JMBeresford
added a commit
that referenced
this pull request
Nov 10, 2025
🤖 I have created a release *beep* *boop* --- ## [0.7.43](v0.7.42...v0.7.43) (2025-11-09) ### Features * update emulatorJS version 4.2.1 -> 4.2.3 ([58de623](58de623)) ### Bug Fixes * built-in ppsspp emulation ([#433](#433)) ([54c97e3](54c97e3)) * cache control header for public files ([2dad54d](2dad54d)) * catch memory access error in web emulation ([08d39c4](08d39c4)) * overlay UI tweaks ([92c4f6f](92c4f6f)) ### Performance Improvements * add database indexes and optimize hot paths ([#427](#427)) ([f80b0e0](f80b0e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.