Repository navigation
In WindowStateTest, compare window location/size with tolerance on Linux - #559
Merged
Alexander Maryanovsky (m-sasha) merged 2 commits intoMay 13, 2023
Merged
Alexander Maryanovsky (m-sasha) merged 2 commits into
Alexander Maryanovsky (m-sasha) merged 2 commits into
Conversation
Alexander Maryanovsky (m-sasha)
force-pushed
the
m-sasha/approximate-window-state-tests
branch
2 times, most recently
from
May 10, 2023 13:15
3a474d9 to
c6c0aa4
Compare
Igor Demin (igordmn)
approved these changes
May 10, 2023
Igor Demin (igordmn)
left a comment
There was a problem hiding this comment.
Checked this test on Windows, pass successfully.
Author
All of |
All of WindowStateTest |
Alexander Maryanovsky (m-sasha)
force-pushed
the
m-sasha/approximate-window-state-tests
branch
from
May 12, 2023 07:11
c6c0aa4 to
c0c3e45
Compare
Alexander Maryanovsky (m-sasha)
force-pushed
the
m-sasha/approximate-window-state-tests
branch
from
May 13, 2023 13:23
f3f1777 to
d6b63f4
Compare
Alexander Maryanovsky (m-sasha)
deleted the
m-sasha/approximate-window-state-tests
branch
May 13, 2023 13:59
Zahari Zahariev (harryzz)
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
Zahari Zahariev (harryzz)
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
Omitting `RunWith(JUnit4::class)` will cause JUnit to use its default runner, which is just what `JUnit4` type aliases. See https://github.com/junit-team/junit4/wiki/Test-runners#runwith-annotation. Test: ./gradlew test connectedCheck Bug: 270612487 This is an imported pull request from androidx#559. Resolves JetBrains#559 Github-Pr-Head-Sha: d9c2977 GitOrigin-RevId: 6825927 Change-Id: Ibb9feb15cf665ba630cfb2f410967835376e20bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Positioning and sizing of not-yet visible, and fullscreen/maximized windows on Linux appears to be inaccurate.
Proposed Changes
When running
WindowStateTests on Linux, compare the location and size of windows with a 10px tolerance.Testing
Test: The unit tests themselves.