Skip to content

fix: border on hidden sidebar - #109

Open
genericallyterrible wants to merge 8 commits into
KiKaraage:mainfrom
genericallyterrible:main
Open

genericallyterrible wants to merge 8 commits into
KiKaraage:mainfrom
genericallyterrible:main

Conversation

@genericallyterrible

Copy link
Copy Markdown

Improves border behavior for the hidden sidebar. Note the line in the bottom left of the "Before" frame

Developed on Firefox 133.0.3 with Sidebery.

before_after

@KiKaraage

Copy link
Copy Markdown
Owner

Will get back to you later once I merged my own update! But yeah I agree on adding a border (or should it be shadow?) when sidebar is not pinned.

@genericallyterrible

Copy link
Copy Markdown
Author

Sounds great! And don't worry if your work invalidates these changes, I'd be happy to close this PR if you find a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants