Repository navigation
Save the 'include images in documents' preference correctly - #219
Merged
Merged
Conversation
WriteXML serialized the boolean ExportImagesInDocuments setting by calling
exportSpace.ToString(), so the preference file always got a space name
('WorldSpace') in that slot. ParseBoolean then read it back as false: the
setting could never be enabled, it reverted to off at every start.
Write the boolean like the other boolean settings. Files written by an older
version are still read as false, which is what they meant anyway.
doha-230
added a commit
to doha-230/Kinovea-Korean
that referenced
this pull request
Sep 28, 2026
Version references move to 2026.5.0 so that the tag, the installer, the artifact names and the version the application reports all agree: - Kinovea/Properties/AssemblyInfo.cs: AssemblyVersion/AssemblyFileVersion were still 2026.1.0.0, so Help > About reported an old version; now 2026.5.0.0 - Installer/kinovea.nsi: default VERSION (used when makensis runs without /DVERSION) - .github/workflows/build.yml: the fallback VERSION for branch builds - readme.md / docs/index.html: version chip, manual footer, tag example Documentation also records that the two fixes stayed upstream: the TRC invariant-culture parsing (upstream PR Kinovea#218) and the 'include images in documents' preference (PR Kinovea#219), plus a changelog row for the upstream sync of this release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WriteXML serialized the boolean ExportImagesInDocuments setting by calling exportSpace.ToString(), so the preference file always got a space name ('WorldSpace') in that slot. ParseBoolean then read it back as false: the setting could never be enabled, it reverted to off at every start.
Write the boolean like the other boolean settings. Files written by an older version are still read as false, which is what they meant anyway.