[Bugfix] stream use text/event-stream media_type - #1011
Merged
Merged
Conversation
Shaoting-Feng
approved these changes
Jul 10, 2025
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Contributor
Author
Done |
Shaoting-Feng
pushed a commit
to Shaoting-Feng/LMCache
that referenced
this pull request
Jul 15, 2025
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
YurianStormrage
pushed a commit
to YurianStormrage/LMCache
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
KevinCheung2259
pushed a commit
to KevinCheung2259/LMCache
that referenced
this pull request
Nov 5, 2025
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
DongDongJu
pushed a commit
to DongDongJu/LMCache
that referenced
this pull request
Feb 22, 2026
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to how vLLM handles it, we set the Content-Type to
text/event-streamfor stream mode, and useapplication/jsonfor the normal case.While this doesn't affect basic
curltesting, it can have an impact on automated testing tools.For example, when using
evalscope perffor benchmarking — it failed to work properly. After investigation, I found thatevalscope perfstrictly parses responses based on the Content-Type, and the mismatch caused the errors.Although it's also reasonable to make
evalscope perfmore tolerant, we can improve the out-of-the-box experience by aligning our Content-Type usage with expectations.PR Checklist (Click to Expand)
Thank you for your contribution to LMCache! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Core]for changes in the core LMCache logic (e.g.,LMCacheEngine,Backendetc.)[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
What to Expect for the Reviews
To create a new tag for lmcache (Note:
vprefix is required):git tag vx.x.xgit push origin vx.x.x(same version again)For example:
git tag v0.3.0git push origin v0.3.0In case the workflow fails, delete the tag and try again:
git tag -d vx.x.xgit push origin :refs/tags/vx.x.xFor example:
git tag -d v0.3.0git push origin :refs/tags/v0.3.0To create a new release and publish
lmcachePython package to PyPi:git remote add upstream git@github.com:LMCache/LMCache.gitgh release create vx.x.x --repo LMCache/LMCache --title "vx.x.x" --notes "<Add description>"For example:
git remote add upstream git@github.com:LMCache/LMCache.gitgh release create v0.3.0 --repo LMCache/LMCache --title "v0.3.0" --notes "LMCache v0.3.0 is a feature release. Users are encouraged to upgrade for the best experience."We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of KuntaiDu, ApostaC or YaoJiayi.