fix(e2e): select role by visible title - #895
Merged
Merged
Conversation
Model: gpt-5.6-sol
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Refs #507
Problem / pressure
The Desktop Daily artifacts for run 35699301315 show
LODY-ROLE-001failing on both macOS and Ubuntu because the role menu item's accessible name includes its binding subtitle. The journey looked up the item by an exact accessible name containing only the role title, so Playwright could not find it.Summary
Select role menu items by their
menuitemradiosemantics and an exact visible role-title descendant. This keeps the selector specific to the requested role without assuming that the title is the item's entire accessible name.Visual explanation
Simple change: the patch only narrows one Playwright locator; a diagram would not add useful review context.
Before / after
Test plan
pnpm run e2e:checkoxfmt --check e2e/src/support/pages/agent-role-page.tsgit diff --check upstream/main...HEADContext handoff
Original user prompt
Show original prompt
Authorized scope completion
The user authorized the assistant to complete the issue link, scope, and cautions from the contribution evidence. For this contribution: follow #507; use the latest Desktop Daily artifacts from run 35699301315; fix the cross-platform
LODY-ROLE-001selector failure without claiming that the unrelated session-bootstrap or context-copy failures are resolved.Shared conversation
Status: unavailable
Reason: This authoring environment does not provide a public HTTP(S) conversation URL. No private conversation content is included in this PR.