Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2009.
Clarify that
lines_after_importscan add a blank line before a comment following the final import even whenensure_newline_before_commentsis false. Add a verified example and a cross-link tolines_after_imports. Explain that isort’s Black profile does not run Black, and that running Black separately adds the blank line in this example.Update both the options documentation and its generator. Sorting behavior is unchanged.
Validation
On Windows 11 with Python 3.13.5:
git diff --checkpassed.The standard documentation build encountered network/SSL errors fetching external fonts. The
done.shwrapper could not invoke nested Bash on this Windows setup, so itsclean.shandtest.shcomponents were run explicitly through Git Bash. Unrelated pre-existing differences between the generated options page and its generator were left unchanged.Codex assisted with the change and ran the checks reported above.