PV horizontal tracking #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest we use 'dual' tracking instead of 'vh', as it's a bit more clear.
The equations don't need to be changed. The 'surface_orientation['slope']' for horizontal tracking (where the slope changes through the day) is calculated in the Orientation.py script.
Also update assertion error
Pv horizontal tracking
PV horizontal tracking
for more information, see https://pre-commit.ci
fneum
approved these changes
May 2, 2023
Member
fneum
left a comment
There was a problem hiding this comment.
Excellent! @FabianHofmann @euronion please merge via #293 if you are happy (it has one additional commit from me cleaning up the example notebook).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was implemented by @Parisra, but she did it in my fork and I reviewed it there.
I have copied below her initial PR description.
The PR include PV horizontal tracking allowing (a) fully horizontal axis, (b) tilted axis.
The azimuth angle of the axis can also be selected.
The most commonly used configuration today is fully horizontal axis oriented N-S.
We followed the implementation in the NREL paper (https://www.nrel.gov/docs/fy13osti/58891.pdf)
This could be relevant for @enrilizaga
closes #140
Change proposed in this Pull Request
Description
This pull request adds two options for solar tracking, namely 1-axis tracking on a North-South horizontal axis, and 1-axis tracking on a tilted North-South axis.
It also changes the name of 2-axes tracking from 'vh' to the more descriptive 'dual'.
Motivation and Context
Since vertical tracking and dual tracking have already been added in a previous pull request(#255), horizontal is now added to complete the tracking options, especially since horizontal tracking is more common in reality today.
How Has This Been Tested?
Type of change
Checklist
pytestinside the repository and no unexpected problems came up.doc/.environment.yamlfile.doc/release_notes.rst.pre-commit run --allto lint/format/check my contribution